feat: native ios support #4049
Merged
feat: native ios support #4049
+196
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Missing bits that are required to release an ios app. This is still WIP
Add support for checking the current state of push notifications when running native
idoshamun
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
omBratteng
reviewed
Jan 16, 2025
Comment on lines
103
to
104
| // eslint-disable-next-line no-console | ||
| console.log('subscription callback', newPermission); |
omBratteng
approved these changes
Jan 16, 2025
sshanzel
reviewed
Jan 17, 2025
| useState, | ||
| } from 'react'; | ||
| import { useQuery, useQueryClient } from '@tanstack/react-query'; | ||
| import type OneSignal from 'react-onesignal'; | ||
| import OneSignal from 'react-onesignal'; |
There was a problem hiding this comment.
Would this not import the OneSignal as a whole all the time now?
There was a problem hiding this comment.
Good catch! Totally missed that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing bits that are required to release an ios app.
Checklist (not everything is applied in this repo):
Preview domain
https://native-ios.preview.app.daily.dev